-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Hadolint #105
base: main
Are you sure you want to change the base?
Introduce Hadolint #105
Conversation
@tillkruss What do you think about OCI metadata? |
cancel-in-progress: true | ||
|
||
jobs: | ||
hadolint: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add this to style.yml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I name actions based on what it cares about, not based on what it does.
E.g. "style" is a job in "back-end" and in "front-end" and in "yaml"
https://github.com/szepeviktor/byte-level-care/tree/master/.github/workflows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you organize workflows based on the activity you will end up with 5 totally different target types in "style.yml".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First let's see its output!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approved the run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the output: https://github.com/szepeviktor/cachewerk_relay/actions/runs/5732711289/job/15536150993
- What rules (e.g
DL3040
) to you want to be corrected? - What rules do you want to be ignored?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the output sorted and grouped by rule code
👉🏻 https://gist.github.com/szepeviktor/16c82e95c3b08906b297a2262728a2bc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of issues and they are pretty strict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the point of my work: prevent future problems.
"Lint" Dockerfiles.
https://github.com/hadolint/hadolint
From #104