-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Domain-wide delegation for Google Calendar and Google Meet #16622
Open
hariombalhara
wants to merge
113
commits into
main
Choose a base branch
from
domain-wide-delegation-google-calendar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,333
−892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
1700348
to
151c3be
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
e123b08
to
6c94a0c
Compare
6c94a0c
to
02529ca
Compare
E2E results are ready! |
02529ca
to
ddade88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app-store
area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar
calendar-apps
area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar
core
area: core, team members only
enterprise
area: enterprise, audit log, organisation, SAML, SSO
✨ feature
New feature or request
platform
Anything related to our platform plan
ready-for-e2e
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Demo - https://www.loom.com/share/1f9e7c79697847a8bb37490e9873fb26
For feature details refer to README
Detailed Changes
getCalendar
now requires value of typeCredentialForCalendarService
which needs an explicit value fordelegatedTo
. It makes it clear to CalendarService how that Credential should be used.delegatedTo=null
.delegatedTo={ serviceAccountKey: { client_email: string; private_key: string; client_id: string;}}
google-calendar/CalendarService
now supports impersonating a user using the ServiceAccount and thus is capable of taking actions on any of the organization member's behalf on the Google Calendar.Calendar Cache support is part of #18619
Release Plan
- Observe errors in Sentry and Axiom.
Automated Tests
Slots Availability - getSchedule.test.ts
Google Calendar Service - Calendar.test.ts
DomainWideDelegation utiltiies and repository - server.test.ts and domainWideDelegation.test.ts
Updating/Setting destinationCalendar - setDestinationCalendar.handler.test.ts
Doing a booking - domain-wide-delegation.test.ts
Fixes CAL-4610
Possible errors when enabling DWD
![image](https://private-user-images.githubusercontent.com/1780212/391980359-abb73487-c8e0-4ac6-bb7f-b03f241d6555.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MDc0MDAsIm5iZiI6MTczOTYwNzEwMCwicGF0aCI6Ii8xNzgwMjEyLzM5MTk4MDM1OS1hYmI3MzQ4Ny1jOGUwLTRhYzYtYmI3Zi1iMDNmMjQxZDY1NTUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMDgxMTQwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZjcxNDkzNWM3Mjc3ZGZmZWVjZDZmZjc1YzY5M2E0MDFjMWE5ZDc2NzQ2ZDUxYmZjM2Q2MGVmMGM2MTcwYzRjZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.chA_pc6YH3KEBGAG8yMJv_KouVMBcFhY19UVeX6bJPI)
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?