Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bulk update event type availability #18850

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: bulk update event type availability #18850

wants to merge 4 commits into from
+42 −31

Conversation

MehulZR
Copy link
Contributor

@MehulZR MehulZR commented Jan 23, 2025

What does this PR do?

Before:

bulk.update.before.mp4

After:

bulk.update.after.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@vercel Vercel
Copy link

vercel bot commented Jan 23, 2025

@MehulZR is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 23, 2025
@graphite-app graphite-app bot requested a review from a team January 23, 2025 23:48
@github-actions github-actions bot added event-types area: event types, event-types 🐛 bug Something isn't working labels Jan 23, 2025
@dosubot dosubot bot added the consumer label Jan 23, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 23, 2025 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/23/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (01/23/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/25/25)

1 label was added to this PR based on Keith Williams's automation.

@MehulZR MehulZR requested a review from Praashh January 24, 2025 17:50
@Praashh
Copy link
Contributor

Praashh commented Jan 25, 2025

can you please fix merge conflict

@MehulZR
Copy link
Contributor Author

MehulZR commented Jan 25, 2025 •
edited
Loading

can you please fix merge conflict

I am sorry, I don't see any.

image

@Praashh
Copy link
Contributor

Praashh commented Jan 25, 2025

yeah fixed now 👍

Praashh
Praashh approved these changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 25, 2025 •
edited
Loading

E2E results are ready!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2025

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Feb 9, 2025
@TusharBhatt1 TusharBhatt1 self-requested a review February 14, 2025 09:52
@MehulZR MehulZR requested a review from a team as a code owner February 14, 2025 09:53
@TusharBhatt1 TusharBhatt1 removed their request for review February 14, 2025 13:03
TusharBhatt1
TusharBhatt1 requested changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@TusharBhatt1 TusharBhatt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to Me the issue occurred because, in the detailed view, the bulk update was triggered before the new schedule ID was saved, causing it to use the outdated value.
This looks an over engineered solution

@MehulZR
Copy link
Contributor Author

MehulZR commented Feb 14, 2025

to Me the issue occurred because, in the detailed view, the bulk update was triggered before the new schedule ID was saved, causing it to use the outdated value. This looks an over engineered solution

Already explained here

@TusharBhatt1
Copy link
Contributor

TusharBhatt1 commented Feb 14, 2025 •
edited
Loading

to Me the issue occurred because, in the detailed view, the bulk update was triggered before the new schedule ID was saved, causing it to use the outdated value. This looks an over engineered solution

Already explained here

Nice effort ! However, to Me the issue could have been fixed with minimal adjustments.

@MehulZR
Copy link
Contributor Author

MehulZR commented Feb 14, 2025

Nice effort ! However, to Me the issue could have been fixed with minimal adjustments.

Just saw your PR. Looks good 👍🏻

I solved the UI quirk.
You made the API compatible with the quirk.

@TusharBhatt1
Copy link
Contributor

TusharBhatt1 commented Feb 14, 2025 •
edited
Loading

Nice effort ! However, to Me the issue could have been fixed with minimal adjustments.

Just saw your PR. Looks good 👍🏻

I solved the UI quirk. You made the API compatible with the quirk.

Ya , shared both with the team for review

@github-actions github-actions bot removed the Stale label Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TusharBhatt1 TusharBhatt1 TusharBhatt1 requested changes

@Praashh Praashh Praashh approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync consumer event-types area: event types, event-types ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bulk Update Schedule Not Applying in Detailed Availability View
3 participants
@MehulZR @Praashh @TusharBhatt1