Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:tempalates functionality WIP #19096

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

nizzyabi
Copy link
Contributor

@nizzyabi nizzyabi commented Feb 4, 2025

What does this PR do?

This is the api call for templates feature we are building on the website. using a json file and connecting to some website code we allow users to copy pre filled templates so they can build routing forms, event types, and workflows quickly.

https://www.loom.com/share/73203081ba2849f69d81cd1916903786

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • run templates pr
  • go to /templates in localhost:3001
  • run this pr
  • click on one of the templates and hit copy
  • What is expected (happy path) to have (input and output)?
    you should be able to see a copied template

@graphite-app graphite-app bot requested a review from a team February 4, 2025 15:54
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "feat:tempalates functionality WIP". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 0:27am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 0:27am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 0:27am

@keithwillcode keithwillcode added the core area: core, team members only label Feb 4, 2025
@dosubot dosubot bot added event-types area: event types, event-types routing-forms area: routing forms, routing, forms workflows area: workflows, automations ✨ feature New feature or request labels Feb 4, 2025
@nizzyabi nizzyabi marked this pull request as draft February 4, 2025 15:54
Copy link

graphite-app bot commented Feb 4, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/04/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (02/07/25)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

E2E results are ready!

Copy link

vercel bot commented Feb 10, 2025

You must have Developer access to commit code to cal on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be in the core app? can we not host this in website or somewhere else?

@nizzyabi
Copy link
Contributor Author

nizzyabi commented Feb 10, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only event-types area: event types, event-types ✨ feature New feature or request ready-for-e2e routing-forms area: routing forms, routing, forms workflows area: workflows, automations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants