chore: migrate api for team upgrade to App Router #19100
+104
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
hbjORbj
changed the title
dosubot
bot
added
api
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/04/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (02/06/25)1 reviewer was added to this PR based on Keith Williams's automation. |
hbjORbj
force-pushed
the
chore/migrate-api-team-upgrade
branch
2 times, most recently
from
9d6a062 to
f17db39
Compare
E2E results are ready! |
hbjORbj
commented
Feb 6, 2025
Comment on lines
+24
to
+28
| const searchParams = req.nextUrl.searchParams; | ||
| const { team: id, session_id } = querySchema.parse({ | ||
| team: params.team, | ||
| session_id: searchParams.get("session_id"), | ||
| }); |
There was a problem hiding this comment.
replacing const { team: id, session_id } = querySchema.parse(req.query); in the pages router api file
hbjORbj
commented
Feb 6, 2025
| ? `${WEBAPP_URL}/settings/organizations/profile?upgraded=true` | ||
| : `${WEBAPP_URL}/settings/teams/${team.id}/profile?upgraded=true`; | ||
|
|
||
| return NextResponse.redirect(redirectUrl); |
There was a problem hiding this comment.
replacing res.redirect(302, redirectUrl); in the pages router api file
hbjORbj
commented
Feb 6, 2025
| const session = await getServerSession({ req: buildLegacyRequest(headers(), cookies()) }); | ||
|
|
||
| if (!session) { | ||
| return NextResponse.json({ message: "Team upgraded successfully" }); |
There was a problem hiding this comment.
replacing { message: "Team upgraded successfully" };
hbjORbj
commented
Feb 6, 2025
| team = await prisma.team.update({ where: { id }, data: { slug } }); | ||
| } catch (error) { | ||
| const { message, statusCode } = getRequestedSlugError(error, slug); | ||
| return NextResponse.json({ message }, { status: statusCode }); |
There was a problem hiding this comment.
replacing return res.status(statusCode).json({ message });
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
/api/teams/[team]/upgrade.tsto App RouterMandatory Tasks (DO NOT REMOVE)
How should this be tested?
/api/teams/${this.team.id}/upgrade?session_id=${paymentId}and see if teamId and session_id are being passed correctly.e.g., I went to
http://localhost:3000/api/teams/12/upgrade?session_id=1010and hadconsole.log(params.team, searchParams.get("session_id"));.result: