Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: atoms and docs update #19137

Merged
merged 8 commits into from
Feb 10, 2025
Merged

chore: atoms and docs update #19137

merged 8 commits into from
Feb 10, 2025

Conversation

Ryukemeister
Copy link
Contributor

@Ryukemeister Ryukemeister commented Feb 6, 2025

What does this PR do?

  • Updated docs for atoms to included missing props
  • Fix css styling issue for booker week view
  • Added dutch translations for CalProvider
  • Remove deprecated endpoint for google connect atom
  • Fixes CAL-5134

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • (N/A) I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • (N/A) I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

This can tested in examples app for atoms under packages/platform/examples/base

@Ryukemeister Ryukemeister requested a review from a team as a code owner February 6, 2025 14:38
@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Feb 6, 2025
@dosubot dosubot bot added the docs area: docs, documentation, cal.com/docs label Feb 6, 2025
Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground 🛑 Canceled (Inspect) Feb 10, 2025 8:00pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 8:00pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 8:00pm

@@ -41,7 +42,7 @@ const CALENDAR_SCOPES = [
path: "/v2/gcal",
version: API_VERSIONS_VALUES,
})
@DocsTags("Platform / Google Calendar")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of the old endpoints we initially had when there was only the google connect atom, good to hide this from docs now.

@@ -85,12 +85,12 @@ Customizations can be done to the destination calendar settings atom via props.
The selected calendar settings atom lets you select which calendars you want to check for conflicts to prevent double bookings. Below code snippet can be used to render the selected calendar settings atom.

```js
import { SelectedCalendarSettings } from "@calcom/atoms";
import { SelectedCalendarsSettings } from "@calcom/atoms";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo fix

export type translationKeys =
| enTranslationKeys
| frTranslationKeys
| deTranslationKeys
| esTranslationKeys
| ptBrTranslationKeys;
| ptBrTranslationKeys
| nlTranslationKeys;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding dutch translations

PeerRich
PeerRich previously approved these changes Feb 10, 2025
@ThyMinimalDev ThyMinimalDev changed the title fix: atoms and docs update chore: atoms and docs update Feb 10, 2025
@ThyMinimalDev
Copy link
Contributor

pushed missing nl translations change within BaseCalProvider g

@ThyMinimalDev ThyMinimalDev enabled auto-merge (squash) February 10, 2025 19:47
Copy link

graphite-app bot commented Feb 10, 2025

Graphite Automations

"Add ready-for-e2e label" took an action on this PR • (02/10/25)

1 label was added to this PR based on Keith Williams's automation.

@ThyMinimalDev ThyMinimalDev merged commit cc6016a into main Feb 10, 2025
39 of 60 checks passed
@ThyMinimalDev ThyMinimalDev deleted the updates-for-atoms branch February 10, 2025 20:05
Copy link
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only docs area: docs, documentation, cal.com/docs platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants