Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create UserCreationService and use in API V1 create user endpoint #19150

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

feat: Create UserCreationService and use in API V1 create user endpoint #19150

wants to merge 20 commits into from
+434 −31

Conversation

joeauyeung
Copy link
Contributor

@joeauyeung joeauyeung commented Feb 7, 2025 •
edited
Loading

What does this PR do?

  • Introduces a UserCreationService
  • Uses the service in API v1 create new user endpoint

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Use v1 API to create a new user

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 7, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 9:21pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 9:21pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 9:21pm

keithwillcode
keithwillcode reviewed Feb 7, 2025
View reviewed changes
packages/lib/server/service/userCreationService.ts
identityProvider?: IdentityProvider;
}

export class UserCreationService {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly what we are looking for with application services coordinating these calls. Very nice.

@joeauyeung joeauyeung mentioned this pull request Feb 9, 2025
Open
3 tasks
joeauyeung
joeauyeung commented Feb 9, 2025
View reviewed changes
packages/lib/server/repository/organization.ts
@@ -90,6 +90,7 @@ export class OrganizationRepository {
email: owner.email,
username: ownerUsernameInOrg,
organizationId: organization.id,
locked: false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll check the new org owner against the watch list in this PR #19201

@joeauyeung joeauyeung marked this pull request as ready for review February 10, 2025 02:46
@joeauyeung joeauyeung requested a review from a team as a code owner February 10, 2025 02:46
@graphite-app graphite-app bot requested a review from a team February 10, 2025 02:47
@dosubot dosubot bot added api area: API, enterprise API, access token, OAuth ✨ feature New feature or request labels Feb 10, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 10, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/10/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 10, 2025 •
edited
Loading

E2E results are ready!

@Udit-takkar Udit-takkar added this to the v5.0 milestone Feb 10, 2025
Udit-takkar
Udit-takkar reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Will you also make these changes in packages/features/auth/lib/next-auth-options.ts in a follow up PR?

@joeauyeung
Copy link
Contributor Author

LGTM. Will you also make these changes in packages/features/auth/lib/next-auth-options.ts in a follow up PR?

@Udit-takkar I have this PR in the stack that addresses this
#19202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithwillcode keithwillcode keithwillcode left review comments

@Udit-takkar Udit-takkar Udit-takkar left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api area: API, enterprise API, access token, OAuth consumer core area: core, team members only ✨ feature New feature or request ready-for-e2e
Projects
None yet
Milestone
v5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@joeauyeung @keithwillcode @Udit-takkar