fix(payments): add return_url for Alipay PaymentIntent confirmation; fixes #19138 #19153
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ShivanshKumar760 is attempting to deploy a commit to the cal-staging Team on Vercel. A member of the Team first needs to authorize it. |
|
|
github-actions
bot
added
billing
dosubot
bot
added
payments
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/07/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (02/07/25)1 label was added to this PR based on Keith Williams's automation. |
anikdhabal
requested changes
Feb 7, 2025
packages/prisma/schema.prisma
Outdated
Comment on lines
5
to
7
| provider = "postgresql" | ||
| url = env("DATABASE_URL") | ||
| //directUrl = env("DATABASE_DIRECT_URL") |
| @@ -178,6 +179,7 @@ const PaymentForm = (props: Props) => { | |||
| payload = await stripe.confirmPayment({ | |||
| elements, | |||
| redirect: "if_required", | |||
| return_url: "https://app.cal.com", // Redirect users to app.cal.com after payment | |||
There was a problem hiding this comment.
No need to hardcode the URL. We have a certain constant; instead, use WEBAPP_URL
Comment on lines
67
to
68
| // return_url: `${window.location.origin}/payment-success`, // adjust this URL as needed | ||
| return_url: "https://app.cal.com", // Redirect users to app.cal.com after payment |
There was a problem hiding this comment.
Remove unnecessary comments
| @@ -1,3 +1,4 @@ | |||
| /*elint-disable*/ | |||
There was a problem hiding this comment.
Removed eslint-disable comment
README.md
Outdated
| @@ -46,7 +46,7 @@ | |||
|
|
|||
| <img width="100%" alt="booking-screen" src="https://github.com/calcom/cal.com/assets/8019099/407e727e-ff19-4ca4-bcae-049dca05cf02"> | |||
|
|
|||
| # Scheduling infrastructure for absolutely everyone | |||
| # Schedulingg infrastructure for absolutely everyone | |||
There was a problem hiding this comment.
Typo in README.md fixed
anikdhabal
reviewed
Feb 10, 2025
Comment on lines
+181
to
+183
| confirmParams: { | ||
| return_url: WEBAPP_URL, | ||
| }, |
There was a problem hiding this comment.
Also, one thing—shouldn't the return_url be the booking success page?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Fixes #19138
This PR addresses the issue where Cal.com was reporting an error from Stripe when confirming a PaymentIntent using Alipay. Stripe requires that a return_url parameter be provided for Alipay payments so that customers can be redirected back to the application after authentication. With this change, the payment confirmation now includes the return_url parameter (set to https://app.cal.com), ensuring that users are properly redirected to our application after an Alipay payment is processed.