chore: Block POST requests to all page routes + remove /user & /user/type dynamic routes from middleware #19281
+93
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbjORbj
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/13/25)1 reviewer was added to this PR based on Keith Williams's automation. |
hbjORbj
changed the title
hbjORbj
changed the title
E2E results are ready! |
hbjORbj
force-pushed
the
chore/block-posts-requests-to-get-routes
branch
from
755fb40 to
45d1732
Compare
hbjORbj
force-pushed
the
chore/block-posts-requests-to-get-routes
branch
from
73fedd1 to
45d1732
Compare
hbjORbj
commented
Feb 14, 2025
Comment on lines
-186
to
-187
| "/:user/:type/", | ||
| "/:user/", |
There was a problem hiding this comment.
these dynamic routes won't go through middleware anymore
Comment on lines
+63
to
+65
| const _pathname = h.get("x-pathname") ?? pathname ?? ""; | ||
| const canonical = buildCanonical({ path: _pathname, origin: origin ?? CAL_URL }); | ||
| const locale = h.get("x-locale") ?? (await getLocale(buildLegacyRequest(h, cookies()))) ?? "en"; |
There was a problem hiding this comment.
routes needed to go through middleware for these 2 special headers: x-pathname and x-locale.
However, getLocale can replace x-locale and hard-coded pathname (passed as arg) can replace x-pathname
hbjORbj
changed the title
hbjORbj
commented
Feb 14, 2025
| @@ -36,7 +36,8 @@ export const generateMetadata = async ({ params, searchParams }: PageProps) => { | |||
| (t) => `${rescheduleUid && !!booking ? t("reschedule") : ""} ${title} | ${profileName}`, | |||
| (t) => `${rescheduleUid ? t("reschedule") : ""} ${title}`, | |||
| isBrandingHidden, | |||
| getOrgFullOrigin(eventData?.entity.orgSlug ?? null) | |||
| getOrgFullOrigin(eventData?.entity.orgSlug ?? null), | |||
| `/${params.user}/${params.type}` | |||
There was a problem hiding this comment.
og:url is being created correctly
hbjORbj
commented
Feb 14, 2025
| @@ -30,7 +30,8 @@ export const generateMetadata = async ({ params, searchParams }: PageProps) => { | |||
| () => profile.name, | |||
| () => markdownStrippedBio, | |||
| false, | |||
| getOrgFullOrigin(entity.orgSlug ?? null) | |||
| getOrgFullOrigin(entity.orgSlug ?? null), | |||
| `/${params.user}` | |||
There was a problem hiding this comment.
og:url is being created correctly
hbjORbj
commented
Feb 14, 2025
| ], | ||
| }; | ||
|
|
||
| export default collectEvents({ | ||
| middleware: abTestMiddlewareFactory(middleware), |
There was a problem hiding this comment.
abTestMiddlewareFactory isn't used and needed (it was testing infra for app dir when we supported /future dir)
hbjORbj
commented
Feb 14, 2025
| @@ -1,9 +0,0 @@ | |||
| import { AB_TEST_BUCKET_PROBABILITY } from "@calcom/lib/constants"; | |||
There was a problem hiding this comment.
abTest dir itself is deprecated
hbjORbj
commented
Feb 14, 2025
| @@ -1,62 +0,0 @@ | |||
| import { getBucket } from "abTest/utils"; | |||
There was a problem hiding this comment.
abTest dir itself is deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
/api(only /api/trpc/:path* and /api/auth/signup go through middleware btw)405 as expected
No 405 as expected for allowed endpoints
/[user]and/[user]/[type]dynamic routes from middleware while ensuring that metadata is still being created correctlyMandatory Tasks (DO NOT REMOVE)
How should this be tested?