Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nested scrolls on /bookings #19284

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: nested scrolls on /bookings #19284

wants to merge 3 commits into from
+46 −2

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Feb 13, 2025 •
edited
Loading

What does this PR do?

This PR removes nested scrolls on /bookings by dynamically applying table height based on some calculations.

Before

Screenshot.2025-02-13.at.17.50.29.mp4

After

Screenshot.2025-02-13.at.17.33.32.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 13, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 4:54pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 4:54pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 4:54pm

@eunjae-lee eunjae-lee marked this pull request as ready for review February 13, 2025 16:52
@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Feb 13, 2025
@graphite-app graphite-app bot requested a review from a team February 13, 2025 16:55
@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 13, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/13/25)

1 reviewer was added to this PR based on Keith Williams's automation.

hbjORbj
hbjORbj previously approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbjORbj hbjORbj hbjORbj left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bookings area: bookings, availability, timezones, double booking consumer core area: core, team members only 🧹 Improvements Improvements to existing features. Mostly UX/UI ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eunjae-lee @hbjORbj @keithwillcode