Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: separate client vs server code from insights layout #19285

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Feb 13, 2025

What does this PR do?

  • Separate client vs server code from app/insights/layout.tsx

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Test /insights pages

@hbjORbj hbjORbj changed the title chore: separate client vs server code from insights layout perf: separate client vs server code from insights layout Feb 13, 2025
@graphite-app graphite-app bot requested a review from a team February 13, 2025 17:21
Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 5:40pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 5:40pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 5:40pm

@keithwillcode keithwillcode added consumer core area: core, team members only labels Feb 13, 2025
@dosubot dosubot bot added the insights area: insights, analytics label Feb 13, 2025
Comment on lines -41 to -42
title={t("insights")}
description={t("insights_subtitle")}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are not needed if withoutSeo is true

Copy link

graphite-app bot commented Feb 13, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/13/25)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Feb 13, 2025

E2E results are ready!

Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice touch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only insights area: insights, analytics ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants