Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flaky test #19294

Merged
merged 11 commits into from
Feb 14, 2025
Merged

fix: flaky test #19294

merged 11 commits into from
Feb 14, 2025
+5 −3

Conversation

Udit-takkar
Copy link
Contributor

@Udit-takkar Udit-takkar commented Feb 14, 2025 •
edited
Loading

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Fixed "can add Attendee Phone Number location and book with it"

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

@vercel Vercel
Copy link

vercel bot commented Feb 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 4:11pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 4:11pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 4:11pm

@graphite-app graphite-app bot requested a review from a team February 14, 2025 10:46
@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Feb 14, 2025
@Udit-takkar Udit-takkar added this to the v5.0 milestone Feb 14, 2025
@dosubot dosubot bot added the automated-tests area: unit tests, e2e tests, playwright label Feb 14, 2025
@Udit-takkar Udit-takkar added ready-for-e2e and removed enterprise area: enterprise, audit log, organisation, SAML, SSO automated-tests area: unit tests, e2e tests, playwright core area: core, team members only labels Feb 14, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 14, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/14/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@Udit-takkar Udit-takkar added the enterprise area: enterprise, audit log, organisation, SAML, SSO label Feb 14, 2025
@keithwillcode keithwillcode added the core area: core, team members only label Feb 14, 2025
eunjae-lee
eunjae-lee previously requested changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

networkIdle is discouraged. Let's find another solution.

@github-actions github-actions bot marked this pull request as draft February 14, 2025 11:19
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 14, 2025 •
edited
Loading

E2E results are ready!

eunjae-lee
eunjae-lee previously approved these changes Feb 14, 2025
View reviewed changes
eunjae-lee
eunjae-lee previously approved these changes Feb 14, 2025
View reviewed changes
@anikdhabal anikdhabal merged commit 1ff4f55 into main Feb 14, 2025
38 of 39 checks passed
@anikdhabal anikdhabal deleted the fix/flaky-test branch February 14, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eunjae-lee eunjae-lee eunjae-lee approved these changes

@anikdhabal anikdhabal anikdhabal left review comments

Assignees
No one assigned
Labels
automated-tests area: unit tests, e2e tests, playwright core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e
Projects
None yet
Milestone
v5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Udit-takkar @eunjae-lee @anikdhabal @keithwillcode