feat: Implement KTX2File #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okwasniewski
changed the title
okwasniewski
requested review from
hmallen99 and
robik
and removed request for
hmallen99 and
robik
|
Free account on GitHub allows for one reviewer so Im going to tag you guys: @robik @hmallen99 @matthargett cc: @thymikee |
okwasniewski
force-pushed
the
feat/ktx2-file
branch
from
1fef836 to
1cf622a
Compare
robik
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements KTX2File class from Basis Universal.
KTX2File
- [x]
BasisModule.KTX2File( new Uint8Array( buffer ) )- [x]
close();- [x]
delete();- [x]
ktx2File.isValid()- [x]
ktx2File.isUASTC()- [x]
BasisFormat.UASTC_4x4- [x]
BasisFormat.ETC1S- [x]
ktx2File.getWidth()- [x]
ktx2File.getHeight();- [x]
ktx2File.getLayers()- [x]
ktx2File.getLevels()- [x]
ktx2File.getFaces();- [x]
ktx2File.getHasAlpha();- [x]
ktx2File.getDFDFlags();- [x]
ktx2File.startTranscoding()- [x]
ktx2File.getImageLevelInfo( mip, layer, face );- [x]
ktx2File.getImageTranscodedSizeInBytes(); - [x]ktx2File.transcodeImage();`Preview of file data:
Test plan