Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to Hook Api with backwards-compatible wrappers #18

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

RasmusKlett
Copy link

It seems the Router moved to a new namespace in the ReasonReact update. I hope you will accept this small fix to adapt.

@RasmusKlett
Copy link
Author

I've rewritten the core to use React Hooks, while keeping the old Component API, and adding .Jsx2 wrappers.
In my opinion, this is really nice to use with Hooks instead of components. Would you be interested in merging this? Some kind of response this time around would be appreciated.

I did not update the examples, as I could not get them to build. I got some error about a -color flag passed to bsb. It seemed like a rabbithole related to reason-scripts.

@RasmusKlett RasmusKlett changed the title Update to ReasonReact 0.7.0 and bucklescript 5.0.1 Refactor to Hook Api with backwards-compatible wrappers Jun 29, 2019
@RasmusKlett
Copy link
Author

Who do I need to contact to get a response? @cnguy @grabbou @knowbody?

@knowbody
Copy link
Contributor

knowbody commented Jul 8, 2019

@RasmusKlett I am no longer a maintainer of this project, but it seems like it's not maintained anymore so you might be better of forking it.

Probably @grabbou will be a better person to give you a more accurate update

@RasmusKlett
Copy link
Author

Ah, that's really too bad. @grabbou can you confirm this repository is dead, and that you will not take a look at my changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants