Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.toml #553

Conversation

DoomedJupiter
Copy link
Collaborator

@DoomedJupiter DoomedJupiter commented Mar 4, 2025

added pillow as a dependency, pillow v10 for below py 3.9 and pillow v11 for py 3.9 and above. Resolves Issue 552. Pillow versions obtained from here

added pillow as a dependency, pillow v10 for below py 3.9 and pillow v11 for py 3.9 and above
@DoomedJupiter
Copy link
Collaborator Author

@bosd first time creating a pr so hopefully I did it right. Also, I just learned about .toml files and I'm not sure how to go about testing this change on my end. From my understanding of how these things work, I think this is the correct change.

@bosd
Copy link
Collaborator

bosd commented Mar 4, 2025

Thanks, I will report back after some sleep.
Manually adding to the toml file is an option.

But it is also needed to update the lock file.
From the cli it is possible to let the package manager make these changes to both files.
I think we're using UV package manager now.

@DoomedJupiter
Copy link
Collaborator Author

After some reading on uv, it looks like it is a terrible option tbh. I'll close this one and make a new with properly generated files.

@DoomedJupiter DoomedJupiter deleted the DoomedJupiter-add-pillow-pkg branch March 4, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies not installed
2 participants