-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support zeebe:TaskListener #67
Conversation
9f117ae
to
ca3cce8
Compare
Please have a look closely at the XML example from camunda/camunda-modeler#4590 (comment) <zeebe:taskListeners>
<zeebe:taskListener eventType="create" type="create_listener" retries="2"/>
<zeebe:taskListener eventType="assignment" type="assignment_listener"/>
<zeebe:taskListener eventType="update" type="update_listener" retries="8"/>
<zeebe:taskListener eventType="complete" type="complete_listener"/>
</zeebe:taskListeners> |
ca3cce8
to
55dba1d
Compare
@barmac I see 👍🏽 I was mislead by the issue name and blindly followed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few last steps before we merge this.
@@ -0,0 +1,11 @@ | |||
<bpmn:task |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this match the expectations. We want the task listeners to be allowed in bpmn:userTask
only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW how come the test is passing if we read a task here and check for user task as the type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it passes for bpmn:userTask
and bpmn:task
but does not for bpmn:endEvent
for example 🤔
Feel free to merge this PR once you're done. |
55dba1d
to
cbb2238
Compare
This adds support for
zeebe:TaskListener
contained inzeebe:TaskListeners
container.related to camunda/camunda-modeler#4590