gh-actions: Add action to install gotestfmt and our wrapper script #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 13, 2024
3v1n0
reviewed
Nov 13, 2024
didrocks
requested changes
Nov 13, 2024
3v1n0
reviewed
Nov 13, 2024
didrocks
reviewed
Nov 13, 2024
adombeck
force-pushed
the
gotestfmt
branch
5 times, most recently
from
7353915 to
0aa426b
Compare
3v1n0
reviewed
Nov 13, 2024
didrocks
requested changes
Nov 14, 2024
didrocks
approved these changes
Nov 14, 2024
Right, sorry, I still forget re-requesting the review sometimes, I'm not used to that workflow. |
The output of go test is notoriously hard to read, especially when a lot of tests are executed and a lot of output is produced. gotestfmt can hide the output of successful tests and put the output of failed tests in an expandable group. This commit adds a custom GitHub Action which installs gotestfmt and a wrapper script which improves the output and copies it to log files, which can then be uploaded as test artifacts.
In the output of the GitHub Actions run, the commands run for each step are collapsed, with only the first line being shown unless it's expanded. It's not helpful if that line is "set -eu" for all our multi-command steps, so we add a comment to the fist line instead which describes what the commands are doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of
go testis notoriously hard to read, especially when a lot of tests are executed and a lot of output is produced. gotestfmt can hide the output of successful tests and put the output of failed tests in an expandable group.This PR adds a custom GitHub Action which installs gotestfmt and a wrapper script which improves the output and copies it to log files, which can then be uploaded as test artifacts.
You can see an example of the produced output when a test fails in this job. A link to the artifacts of that job can be found in the "Upload test artifacts" step of that job.