cleanup(gh-actions/build-debian): Unify steps common tasks and make apt faster #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3v1n0
force-pushed
the
cleanup-build-deb
branch
3 times, most recently
from
7926742 to
c06d606
Compare
3v1n0
force-pushed
the
cleanup-build-deb
branch
from
1e197c8 to
c9b36f6
Compare
|
@didrocks can you give this a look please? :) |
3v1n0
force-pushed
the
cleanup-build-deb
branch
from
140d56a to
020cdd5
Compare
didrocks
requested changes
Jan 23, 2025
3v1n0
force-pushed
the
cleanup-build-deb
branch
from
9a96a9b to
140bfb6
Compare
|
Cool, FYI I've dropped the last commit since it got upstreamed at canonical/setup-lxd#25 :) |
… script We can just use a script from this repo in order to do the common steps that each container run requires
No need to copy the script around, we can just reuse the one from this repository, since it's now in the action path
…step There's no need to add multiple steps
In this way we can avoid issues in case the variable contains quotes
… installation We can save some time by avoiding apt to install man pages and parsing them to build the man-db. Plus, locales aren't normally required unless they're explicit build-dependencies of a package (that may requires them for testing some special case).
eatmydata allows faster builds and it's something that is used also by default by mk-sbuild these days, so enable it by default here too.
It's what the CI terminal is
3v1n0
force-pushed
the
cleanup-build-deb
branch
from
140bfb6 to
c8f3aee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the action and move the common docker steps in a script that is shared by all the steps.