Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gh-actions): Add run-autopkgtest action #58

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

3v1n0
Copy link
Contributor

@3v1n0 3v1n0 commented Dec 19, 2024

It allows to run autopkgtests in an LXD container for a both a source
files and/or provided built debs

Add test cases

UDENG-2343

@3v1n0 3v1n0 requested a review from adombeck December 19, 2024 04:41
@3v1n0 3v1n0 requested a review from didrocks as a code owner December 19, 2024 04:41
@3v1n0 3v1n0 changed the title feat(gh-actions: Add run-autopkgtest action) feat(gh-actions): Add run-autopkgtest action Dec 19, 2024
@3v1n0 3v1n0 force-pushed the run-autopkgtests branch 2 times, most recently from 90964be to 2d9588a Compare December 19, 2024 04:44
Copy link
Collaborator

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Was long to review, but I didn’t spot anything major, just a couple of comments.

My only biggest questions would be: Why do we need to build the source package and deb ourself? IIRC, adt also has this mode to build those if necessary (but I’m less up to date on autopkgtest-build-*)

@3v1n0
Copy link
Contributor Author

3v1n0 commented Jan 16, 2025

My only biggest questions would be: Why do we need to build the source package and deb ourself? IIRC, adt also has this mode to build those if necessary (but I’m less up to date on autopkgtest-build-*)

Well, that's for saving time when we already build everything ourself... Like in the authd case we still want to be able to build things and in some cases run autopkgtests, so I prefer to keep the phases separated.

@3v1n0 3v1n0 requested a review from didrocks January 16, 2025 20:39
Copy link
Collaborator

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the rationale makes sense. That is going to be useful :)

3v1n0 added 3 commits January 17, 2025 17:03
Add new inputs so that it's possible to only build source packages or
binary packages from a provided source file.

This will help testing further cases where we only care about source
files
It allows to run autopkgtests in an LXD container for a both a source
files and/or provided built debs

Add test cases
@3v1n0 3v1n0 merged commit 902b13f into canonical:main Jan 17, 2025
6 checks passed
3v1n0 added a commit to ubuntu/authd that referenced this pull request Jan 23, 2025
Add a workflow to build debian packages and run autopkgtests.

Requires: canonical/desktop-engineering#58 

UDENG-2343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants