Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gh-actions): Add macOS compatibility for go code-sanity and gotestfmt #60

Merged
merged 3 commits into from
Jan 15, 2025
Merged

feat(gh-actions): Add macOS compatibility for go code-sanity and gotestfmt #60

merged 3 commits into from
Jan 15, 2025

Conversation

hk21702
Copy link
Contributor

@hk21702 hk21702 commented Jan 14, 2025

Updates to add macOS compatibility for go code-sanity and gotestfmt

  • Use brew to install jq in code-sanity
  • Remove and replace unsupported flags in the install command for gotestfmt
    • Use mkdir instead of -D
    • Remove -t
    • Use -m instead of --mode

Minor spelling fix

UDENG-5777

@hk21702 hk21702 self-assigned this Jan 14, 2025
@hk21702 hk21702 changed the title feat(gh-actions): add macOS compatibility for go code-sanity and gotestfmt feat(gh-actions): Add macOS compatibility for go code-sanity and gotestfmt Jan 14, 2025
@hk21702 hk21702 changed the title feat(gh-actions): Add macOS compatibility for go code-sanity and gotestfmt feat(gh-actions): Add macOS compatibility for go code-sanity and gotestfmt Jan 14, 2025
@hk21702 hk21702 marked this pull request as ready for review January 14, 2025 19:10
@hk21702 hk21702 requested a review from didrocks as a code owner January 14, 2025 19:10
didrocks
didrocks approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, easy and great that this is enough to support Mac OS! :)

Nice work!

@hk21702 hk21702 merged commit 6a5b7c9 into canonical:main Jan 15, 2025
4 of 6 checks passed
@hk21702 hk21702 deleted the UDENG-5777-add-macos-compatibility-for-desktop-github-actions branch January 15, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didrocks didrocks didrocks approved these changes

Assignees

@hk21702 hk21702

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hk21702 @didrocks