Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: export types from barrel file #88

Merged
merged 5 commits into from
Jan 26, 2025
Merged

refactor!: export types from barrel file #88

merged 5 commits into from
Jan 26, 2025

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented Aug 18, 2024

Currently, this library uses sveld to generate TypeScript definitions.

This is a breaking change that instead re-exports and re-uses a base CarbonPictogram class from the barrel file. Reasons are as follows:

  • Smaller package
  • Much faster to build the library
  • Consistent with the approach by carbon-icons-svelte

There should technically be no functional changes, but a major version bump is likely warranted.


Before

npm notice package size:  698.1 kB                                
npm notice unpacked size: 3.2 MB                                  
npm notice total files:   2371   

After

npm notice package size:  681.6 kB                                
npm notice unpacked size: 2.8 MB
npm notice total files:   2371

@metonym metonym merged commit f51c80a into master Jan 26, 2025
3 checks passed
@metonym metonym deleted the refactor-types branch January 26, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant