Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: theme neutral color token for popover bg when overlapping zoned theming #11347

Open
1 task done
jnm2377 opened this issue May 4, 2022 · 3 comments · May be fixed by #18732
Open
1 task done

[Bug]: theme neutral color token for popover bg when overlapping zoned theming #11347

jnm2377 opened this issue May 4, 2022 · 3 comments · May be fixed by #18732

Comments

@jnm2377
Copy link
Contributor

jnm2377 commented May 4, 2022

Summary

This issue was brought up when migrating the Carbon tutorial to v11.
In the tutorial, we have the header as g100 and the content as white. The UI shell icon buttons all use tooltips (since all our icon only buttons do for a11y). We realized that when the tooltip was showing, the g100 theme tooltip bg color was a light color, which blended in too much with the white bg content.

This might not be the only time something like this happens when zoned themes have popover content that overlap with the different themes.
Screen Shot 2022-04-28 at 1 58 12 PM

Screen Shot 2022-04-28 at 1 57 43 PM

One of the options we considered was having a theme neutral color token for these situations. But then also need a way to be able to select that or configure that.

For the time being, we used $gray-20 as the tooltip bg color (per design guidance).

Justification

Better visibility and a11y. When the color blends in too much with one theme, it can be easy to miss the content.

Desired UX and success metrics

No response

Required functionality

Ability to be able to easily configure (via prop or something) a theme neutral bg color

Specific timeline issues / requests

No response

Available extra resources

No response

Code of Conduct

@jnm2377 jnm2377 added component: tooltip component: ui-shell package: themes @carbon/themes component: popover package: @carbon/react @carbon/react proposal: open This request has gone through triaging. We're determining whether we take this on or not. labels May 4, 2022
@jnm2377 jnm2377 removed this from Design System May 4, 2022
@jnm2377 jnm2377 moved this to 🕵️‍♀️ Triage in Design System May 4, 2022
@sstrubberg sstrubberg changed the title [Feature Request]: theme neutral color token for popover bg when overlapping zoned theming [Bug]: theme neutral color token for popover bg when overlapping zoned theming Jul 25, 2022
@sstrubberg
Copy link
Member

Just chatted about this one in Backlog Cleaning. We decided that this was more of a bug than a feature and prioritized it as such. We want to see if other v11 adopters experience this before prioritizing the work because there will need to be some research sprint(s) to figure out a path forward. Thanks for logging this!

@jnm2377 jnm2377 removed the proposal: open This request has gone through triaging. We're determining whether we take this on or not. label Aug 25, 2022
@tay1orjones tay1orjones moved this from 🕵️‍♀️ Triage to ⏱ Backlog in Design System Dec 7, 2022
@tay1orjones
Copy link
Member

Is this resolved by #18636? Sort of seems like it. @alisonjoseph @emyarod if you agree we could close this

@alisonjoseph alisonjoseph self-assigned this Feb 28, 2025
@alisonjoseph alisonjoseph moved this from ⏱ Backlog to 🏗 In Progress in Design System Feb 28, 2025
@alisonjoseph alisonjoseph moved this from 🏗 In Progress to 🚦 In Review in Design System Feb 28, 2025
@emyarod
Copy link
Member

emyarod commented Feb 28, 2025

Is this resolved by #18636? Sort of seems like it. @alisonjoseph @emyarod if you agree we could close this

yes along with #18725 I believe this issue is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🚦 In Review
Development

Successfully merging a pull request may close this issue.

5 participants