feat: make highContrast and dropShadow props configurable
#18636
+60
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18636 +/- ##
=======================================
Coverage 84.92% 84.92%
=======================================
Files 408 408
Lines 14501 14505 +4
Branches 4729 4703 -26
=======================================
+ Hits 12315 12319 +4
Misses 2025 2025
Partials 161 161 ☔ View full report in Codecov by Sentry. |
riddhybansal
approved these changes
Feb 20, 2025
Merged
via the queue into
carbon-design-system:main
with commit Feb 20, 2025
23a11c1
38 checks passed
1 task
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related carbon-design-system/carbon-labs#418 #11347
This PR makes the
highContrastanddropShadowPopover props configurable in the Tooltip and IconButton. The default values will remain as-is, but this change will allow the new UI shell side nav variant to inherit these styles as needed without the style overrides.Changelog
Changed
highContrastanddropShadowprops in the Tooltip and IconButton