Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shape-indicator): new component #18483

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

ariellalgilmore
Copy link
Member

@ariellalgilmore ariellalgilmore commented Jan 29, 2025

Closes #17540

worked on with @Gururajj77 !!!

Implement shape indicator

Changelog

New

  • new Shape Indicator component for react and web components
  • new stories, styles, tests, and readme's
  • new tokens for the yellow and orange outline

Testing / Reviewing

Go to shape indicator story for both React and Web Components and compare to specs

Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 29c260d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67c63ca098814300088d4bc7
😎 Deploy Preview https://deploy-preview-18483--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 29c260d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67c63ca082f7780008b78f4a
😎 Deploy Preview https://deploy-preview-18483--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 29c260d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67c63ca08b04bf0008cb38d2
😎 Deploy Preview https://deploy-preview-18483--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.26%. Comparing base (4ee4dc5) to head (29c260d).

Files with missing lines Patch % Lines
...ages/react/src/components/ShapeIndicator/index.tsx 85.71% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18483   +/-   ##
=======================================
  Coverage   84.26%   84.26%           
=======================================
  Files         408      409    +1     
  Lines       14661    14677   +16     
  Branches     4777     4829   +52     
=======================================
+ Hits        12354    12368   +14     
- Misses       2144     2145    +1     
- Partials      163      164    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thyhmdo
Copy link
Member

thyhmdo commented Feb 24, 2025

Web component

the size is correct in web component but can we clarify that this is the text size?

image

Incomplete has the incorrect icon
image
It should be this one
image

React

React needs an update for 12 and 14 instead of 16 and 20. It also needs a clarification of text size.
image

@ariellalgilmore
Copy link
Member Author

@thyhmdo just updated! thank you!

Copy link
Member

@thyhmdo thyhmdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thanks

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! 🥳

Copy link
Contributor

@preetibansalui preetibansalui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome to me, just minor change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Status indicators] Implement Shape indicator
5 participants