-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shape-indicator): new component #18483
base: main
Are you sure you want to change the base?
feat(shape-indicator): new component #18483
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18483 +/- ##
=======================================
Coverage 84.26% 84.26%
=======================================
Files 408 409 +1
Lines 14661 14677 +16
Branches 4777 4829 +52
=======================================
+ Hits 12354 12368 +14
- Misses 2144 2145 +1
- Partials 163 164 +1 ☔ View full report in Codecov by Sentry. |
@thyhmdo just updated! thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM! 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome to me, just minor change.
Closes #17540
worked on with @Gururajj77 !!!
Implement shape indicator
Changelog
New
Testing / Reviewing
Go to shape indicator story for both React and Web Components and compare to specs