-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(FloatingMenu): rewrite in typescript #18722
base: main
Are you sure you want to change the base?
refactor(FloatingMenu): rewrite in typescript #18722
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18722 +/- ##
==========================================
- Coverage 84.26% 84.22% -0.05%
==========================================
Files 408 408
Lines 14661 14653 -8
Branches 4827 4826 -1
==========================================
- Hits 12354 12341 -13
- Misses 2143 2159 +16
+ Partials 164 153 -11 ☔ View full report in Codecov by Sentry. |
Closes #18720
Rewrote
FloatingMenu
in TypeScript.Changelog
Changed
FloatingMenu
in TypeScript.wrapFocus
util andOverflowMenu
component.Testing / Reviewing
yarn test packages/react/src/components/OverflowMenu
I left a
TODO
in the code. Curious to hear others' thoughts.I didn't see a reason to memoize
handleMenuRef
or put it in auseCallback
. If someone finds one, this code should work.