Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TableExpandHeader): update prop types #18729

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamalston
Copy link
Contributor

Closes #18715

Updated TableExpandHeader prop types.

Changelog

New

  • Added the deprecated tag to enableExpando in TableExpandHeaderPropsWithExpando since the enableExpando prop in TableExpandHeaderPropsBase was being overridden.

Removed

  • Removed the ariaLabel override from TableExpandHeaderPropsWithToggle and TableExpandHeaderPropsWithExpando.

Testing / Reviewing

Paste the code from the reproduction at the bottom of packages/react/src/components/DataTable/TableExpandHeader.tsx and check for type errors.

I read through #14386 and I think these changes comply with everything there.

Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit f3355cc
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67c1c1b1bf54900008ad4a6f
😎 Deploy Preview https://deploy-preview-18729--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit f3355cc
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67c1c1b1ed1fd00008e2a31a
😎 Deploy Preview https://deploy-preview-18729--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f3355cc
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67c1c1b1d6d4f70008f3bcad
😎 Deploy Preview https://deploy-preview-18729--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.34%. Comparing base (1d57a3a) to head (f3355cc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18729   +/-   ##
=======================================
  Coverage   84.34%   84.34%           
=======================================
  Files         408      408           
  Lines       14645    14645           
  Branches     4791     4771   -20     
=======================================
  Hits        12352    12352           
- Misses       2131     2132    +1     
+ Partials      162      161    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamalston adamalston marked this pull request as ready for review February 28, 2025 14:26
@adamalston adamalston requested review from a team as code owners February 28, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TableExpandHeader throws a type error for ariaLabel which is deprecated
1 participant