Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use .nvmrc for node versioning in workflows #18736

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

adamalston
Copy link
Contributor

Closes #18735

Updated workflows to use .nvmrc for Node versioning.

Changelog

Changed

  • Updated workflows to use .nvmrc for Node versioning.

Testing / Reviewing

I added a TODO that I'm curious to hear thoughts on.

Copy link

netlify bot commented Mar 1, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit b94924b
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67c5d7527c662b000838f82a
😎 Deploy Preview https://deploy-preview-18736--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 1, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit b94924b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67c5d752e1a9c600089bb5a1
😎 Deploy Preview https://deploy-preview-18736--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 1, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b94924b
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67c5d7529203de0008476d25
😎 Deploy Preview https://deploy-preview-18736--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.26%. Comparing base (78263b3) to head (b94924b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18736   +/-   ##
=======================================
  Coverage   84.26%   84.26%           
=======================================
  Files         408      408           
  Lines       14661    14661           
  Branches     4797     4827   +30     
=======================================
  Hits        12354    12354           
- Misses       2143     2144    +1     
+ Partials      164      163    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamalston adamalston marked this pull request as ready for review March 1, 2025 17:19
@adamalston adamalston requested review from a team as code owners March 1, 2025 17:19
@adamalston adamalston requested a review from kennylam March 1, 2025 17:19
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, this should be updated as well. I think we can scrap cache as well. Thanks!

@adamalston adamalston requested a review from kennylam March 3, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use .nvmrc for Node versioning in workflows
2 participants