-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use .nvmrc for node versioning in workflows #18736
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18736 +/- ##
=======================================
Coverage 84.26% 84.26%
=======================================
Files 408 408
Lines 14661 14661
Branches 4797 4827 +30
=======================================
Hits 12354 12354
- Misses 2143 2144 +1
+ Partials 164 163 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, this should be updated as well. I think we can scrap cache
as well. Thanks!
Closes #18735
Updated workflows to use .nvmrc for Node versioning.
Changelog
Changed
Testing / Reviewing
I added a
TODO
that I'm curious to hear thoughts on.