Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon-helpers): specify types entrypoint #18739

Merged

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented Mar 2, 2025

The @carbon/icon-helpers package includes TypeScript definitions, but is missing an explicit types entrypoint in the package.json.

Changelog

Changed

  • fix(icon-helpers): specify types entrypoint

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

@metonym metonym requested review from a team as code owners March 2, 2025 18:02
Copy link

netlify bot commented Mar 2, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 1bc111e
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67c49d39dd9bb400089dc4c3
😎 Deploy Preview https://deploy-preview-18739--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 2, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 1bc111e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67c49d39bac1b0000887461f
😎 Deploy Preview https://deploy-preview-18739--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 2, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1bc111e
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67c49d394dba600008e53874
😎 Deploy Preview https://deploy-preview-18739--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.34%. Comparing base (448a2b7) to head (1bc111e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18739   +/-   ##
=======================================
  Coverage   84.34%   84.34%           
=======================================
  Files         408      408           
  Lines       14645    14645           
  Branches     4771     4821   +50     
=======================================
  Hits        12352    12352           
+ Misses       2132     2131    -1     
- Partials      161      162    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@preetibansalui preetibansalui added this pull request to the merge queue Mar 3, 2025
Merged via the queue into carbon-design-system:main with commit 78263b3 Mar 3, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants