Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds forwardRef to OperationalTag #18741

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

2nikhiltom
Copy link
Contributor

Closes #18522

Added forwardRef support to OperationalTag
added test case against it

Changelog

New
adds forwardRef support

Testing / Reviewing

ci checks should pass
existing functionally remain intact

@2nikhiltom 2nikhiltom requested review from a team as code owners March 3, 2025 10:24
Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 98af23c
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67c5837457387a0008c2ba72
😎 Deploy Preview https://deploy-preview-18741--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 98af23c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67c5837443eadd000898c3fa
😎 Deploy Preview https://deploy-preview-18741--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 98af23c
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67c58374f00f1e00083f202c
😎 Deploy Preview https://deploy-preview-18741--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.26%. Comparing base (2d59305) to head (98af23c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/react/src/components/Tag/OperationalTag.tsx 81.25% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18741   +/-   ##
=======================================
  Coverage   84.26%   84.26%           
=======================================
  Files         408      408           
  Lines       14659    14660    +1     
  Branches     4825     4825           
=======================================
+ Hits        12352    12353    +1     
- Misses       2143     2144    +1     
+ Partials      164      163    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: OperationalTag should forward ref
2 participants