Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop CommitIgnored #1898

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Drop CommitIgnored #1898

wants to merge 1 commit into from

Conversation

ch1bo
Copy link
Member

@ch1bo ch1bo commented Mar 13, 2025

TBD: Should we keep it and find better semantics? I don't understand it's original meaning so I just dropped it.

This was spamming clients as it was emitted even when we were not even having any pending deposits.

image


  • CHANGELOG updated or not needed
  • Documentation updated or not needed
  • Haddocks updated or not needed
  • No new TODOs introduced or explained herafter

@ch1bo ch1bo requested a review from a team March 13, 2025 18:23
@ch1bo ch1bo self-assigned this Mar 13, 2025
Copy link

github-actions bot commented Mar 13, 2025

Transaction cost differences

Script summary

Name Size (Bytes)
νInitial -
νCommit -
νHead -
μHead -
νDeposit -

Init transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 - - - -
2 - - - -
3 - - - -
5 - - - -
10 - - - -
40 - - - -

Commit transaction costs

UTxO Tx size % max Mem % max CPU Min fee ₳
1 - - - -
2 - - - -
3 - - - -
5 - - - -
10 - - - -
54 - - - -

CollectCom transaction costs

Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
1 - - - - -
2 - - - - -
3 - - - - -
4 - - - - -
5 - - - - -
6 - - - - -
7 - - - - -
8 - - - - -

Cost of Increment Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 - - - -
2 - - - -
3 - - - -
5 - +0.39 +0.09 -
10 - - - -
37 - $${\color{green}-0.39}$$ $${\color{green}-0.09}$$ -

Cost of Decrement Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 - - - -
2 - - - -
3 - - - -
5 - - - -
10 - - - -
40 - - - -

Close transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 - - - -
2 - - - -
3 - - - -
5 - - - -
10 - - - -
34 - - - -

Contest transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 - - - -
2 - - - -
3 - - - -
5 - - - -
10 - - - -
27 - - - -

FanOut transaction costs

UTxO, Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
(0, 10) - - - - -
(1, 10) - - - - -
(5, 10) - - - - -
(10, 10) - - - - -
(20, 10) - - - - -
(37, 10) - - - - -

Copy link

github-actions bot commented Mar 13, 2025

Transaction costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2025-03-14 09:35:04.343716002 UTC
Max. memory units 14000000
Max. CPU units 10000000000
Max. tx size (kB) 16384

Script summary

Name Hash Size (Bytes)
νInitial c8a101a5c8ac4816b0dceb59ce31fc2258e387de828f02961d2f2045 2652
νCommit 61458bc2f297fff3cc5df6ac7ab57cefd87763b0b7bd722146a1035c 685
νHead 0e35115a2c7c13c68ecd8d74e4987c04d4539e337643be20bb3274bd 14756
μHead 57166715eadb8d3135964325c016eea546c21e1c0aae974ca67df9a5* 5541
νDeposit ae01dade3a9c346d5c93ae3ce339412b90a0b8f83f94ec6baa24e30c 1102
  • The minting policy hash is only usable for comparison. As the script is parameterized, the actual script is unique per head.

Init transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 6094 11.11 3.46 0.53
2 6294 13.35 4.15 0.56
3 6496 15.71 4.88 0.60
5 6897 19.98 6.17 0.66
10 7901 31.18 9.61 0.82
40 13936 98.39 30.22 1.78

Commit transaction costs

This uses ada-only outputs for better comparability.

UTxO Tx size % max Mem % max CPU Min fee ₳
1 561 2.44 1.16 0.20
2 742 3.38 1.73 0.22
3 923 4.36 2.33 0.24
5 1281 6.41 3.60 0.28
10 2170 12.13 7.25 0.40
54 10062 98.61 68.52 1.88

CollectCom transaction costs

Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
1 57 529 26.44 7.58 0.44
2 114 636 35.97 10.25 0.54
3 170 747 44.56 12.69 0.63
4 226 858 53.36 15.19 0.73
5 284 969 62.54 17.77 0.83
6 339 1081 67.81 19.53 0.89
7 396 1192 89.00 24.97 1.10
8 449 1303 84.87 24.33 1.07

Cost of Increment Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 1794 25.50 8.33 0.50
2 1934 26.73 9.41 0.52
3 2200 30.84 11.46 0.58
5 2375 32.59 13.29 0.61
10 3187 43.66 20.26 0.79
39 7471 99.21 57.38 1.69

Cost of Decrement Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 612 23.99 7.61 0.43
2 743 25.62 8.73 0.45
3 901 28.33 10.14 0.49
5 1085 28.66 11.54 0.51
10 1950 41.74 18.49 0.71
38 6251 98.63 52.83 1.60

Close transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 679 30.95 9.69 0.50
2 774 32.89 10.93 0.53
3 974 32.81 11.67 0.54
5 1224 36.52 14.12 0.60
10 1975 46.76 20.79 0.76
34 5873 99.43 54.36 1.60

Contest transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 695 35.99 11.02 0.55
2 826 38.19 12.34 0.58
3 944 40.25 13.62 0.62
5 1289 46.00 16.86 0.70
10 2024 56.94 23.49 0.87
27 4645 98.22 48.00 1.49

Abort transaction costs

There is some variation due to the random mixture of initial and already committed outputs.

Parties Tx size % max Mem % max CPU Min fee ₳
1 5981 28.33 9.33 0.71
2 6099 37.59 12.38 0.81
3 6213 46.54 15.35 0.91
4 6393 57.45 18.95 1.03
5 6432 65.69 21.61 1.12
6 6646 74.16 24.52 1.22
7 6928 88.97 29.52 1.39
8 6961 93.41 30.88 1.43

FanOut transaction costs

Involves spending head output and burning head tokens. Uses ada-only UTXO for better comparability.

Parties UTxO UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
10 0 0 6091 20.12 6.62 0.63
10 5 284 6260 30.97 10.82 0.75
10 10 569 6430 41.42 14.88 0.88
10 20 1137 6768 62.26 22.99 1.12
10 30 1708 7111 85.79 32.00 1.39
10 37 2106 7348 99.40 37.34 1.55

End-to-end benchmark results

This page is intended to collect the latest end-to-end benchmark results produced by Hydra's continuous integration (CI) system from the latest master code.

Please note that these results are approximate as they are currently produced from limited cloud VMs and not controlled hardware. Rather than focusing on the absolute results, the emphasis should be on relative results, such as how the timings for a scenario evolve as the code changes.

Generated at 2025-03-14 09:38:02.501346891 UTC

Baseline Scenario

Number of nodes 1
Number of txs 300
Avg. Confirmation Time (ms) 4.231431410
P99 5.279939969999999ms
P95 4.839982200000001ms
P50 4.1496365ms
Number of Invalid txs 0

Memory data

Time Used Free
2025-03-14 09:36:46.512209986 UTC 929M 6217M
2025-03-14 09:36:51.512416952 UTC 1001M 6113M
2025-03-14 09:36:56.51207619 UTC 1013M 6101M
2025-03-14 09:37:01.512167447 UTC 1014M 6100M
2025-03-14 09:37:06.512072719 UTC 1016M 6098M
2025-03-14 09:37:11.512074458 UTC 1016M 6097M

Three local nodes

Number of nodes 3
Number of txs 900
Avg. Confirmation Time (ms) 27.223141243
P99 40.67442947999999ms
P95 37.07381604999999ms
P50 25.962047499999997ms
Number of Invalid txs 0

Memory data

Time Used Free
2025-03-14 09:37:24.598028312 UTC 947M 6176M
2025-03-14 09:37:29.598102884 UTC 1199M 5922M
2025-03-14 09:37:34.59890323 UTC 1252M 5811M
2025-03-14 09:37:39.598140859 UTC 1261M 5750M
2025-03-14 09:37:44.598054584 UTC 1270M 5741M
2025-03-14 09:37:49.598107965 UTC 1274M 5736M
2025-03-14 09:37:54.598055515 UTC 1277M 5733M
2025-03-14 09:37:59.598137344 UTC 1283M 5726M

@noonio
Copy link
Contributor

noonio commented Mar 14, 2025

Seems like a good plan; @v0d1ch probably needs to make the final call; but if deleting it didn't cause anything to fail, seems like it wasn't required! Probably it was useful for debugging.

This was spamming clients as it was emitted even when we were not even
having any pending deposits.
@noonio noonio force-pushed the no-commit-ignored branch from fc078d5 to 8011c74 Compare March 14, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In review 👀
Development

Successfully merging this pull request may close these issues.

3 participants