fix: removed a few analytics api

carforyou · Mar 21, 2022 · 3fe598b · 3fe598b
1 parent db166a8
commit 3fe598b
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 216 deletions.
diff --git a/README.md b/README.md
@@ -228,9 +228,6 @@ Also accompanying modes and param types, as well as default values, are exported
 
 - [Analytics](https://internal.carforyou.dev/api-docs/swagger-ui/?urls.primaryName=reporting-service#/Analytics)
   - [`fetchAnalyticsData`](https://internal.carforyou.dev/api-docs/swagger-ui/?urls.primaryName=reporting-service#/Analytics/getDealerListingsMetrics)
-  - [`fetchLeadsAnalytics`](https://reporting-service.preprod.carforyou.ch/swagger-ui/index.html#/Analytics/getDealerLeadsAnalyticsUsingPOST)
-  - [`fetchListingsAnalytics`](https://reporting-service.preprod.carforyou.ch/swagger-ui/index.html#/Analytics/getDealerListingsAnalyticsUsingPOST),
-  - [`fetchLeadsInteractionsAnalytics`](https://reporting-service.preprod.carforyou.ch/swagger-ui/index.html#/Analytics/getDealerLeadsInteractionsUsingPOST)
   - [`fetchDealerAnalytics`](https://internal.carforyou.dev/api-docs/swagger-ui/?urls.primaryName=reporting-service#/Analytics/getDealerAnalytics)
 
 

diff --git a/src/index.ts b/src/index.ts
@@ -303,13 +303,7 @@ export {
   extendSavedSearch,
   sendSavedSearchFeedback,
 } from "./services/userNotification"
-export {
-  fetchAnalyticsData,
-  fetchLeadsAnalytics,
-  fetchListingsAnalytics,
-  fetchLeadsInteractionsAnalytics,
-  fetchDealerAnalytics,
-} from "./services/analytics"
+export { fetchAnalyticsData, fetchDealerAnalytics } from "./services/analytics"
 export { postWhatsappTrackingEntry } from "./services/reporting/whatsapp"
 export { postCallTrackingEntry } from "./services/reporting/callTracking"
 export { fetchReferenceData } from "./services/referenceData"

diff --git a/src/services/__tests__/analytics.test.ts b/src/services/__tests__/analytics.test.ts
@@ -1,10 +1,4 @@
-import {
-  fetchAnalyticsData,
-  fetchDealerAnalytics,
-  fetchLeadsAnalytics,
-  fetchLeadsInteractionsAnalytics,
-  fetchListingsAnalytics,
-} from "../analytics"
+import { fetchAnalyticsData, fetchDealerAnalytics } from "../analytics"
 import { DealerAnalytics } from "../../types/models"
 
 describe("Analytics service", () => {
@@ -58,134 +52,6 @@ describe("Analytics service", () => {
     })
   })
 
-  describe("#fetchLeadsAnalytics", () => {
-    const analyticsData = [
-      {
-        count: 10,
-      },
-    ]
-
-    beforeEach(() => {
-      fetchMock.mockResponse(JSON.stringify(analyticsData))
-    })
-
-    it("fetches the data", async () => {
-      const data = await fetchLeadsAnalytics({
-        dealerId: 123,
-        options: { accessToken: "TOKEN" },
-      })
-
-      expect(data).toEqual(analyticsData)
-      expect(fetch).toHaveBeenCalled()
-    })
-
-    it("sends query in the request body", async () => {
-      await fetchLeadsAnalytics({
-        dealerId: 123,
-        options: { accessToken: "TOKEN" },
-      })
-
-      expect(fetch).toHaveBeenCalledWith(
-        expect.stringContaining(`/dealers/123/leads/analytics`),
-        expect.objectContaining({
-          body: JSON.stringify({
-            function: "count",
-          }),
-        })
-      )
-    })
-  })
-
-  describe("#fetchLeadsInteractionsAnalytics", () => {
-    const analyticsData = [
-      {
-        type: "message",
-        count: 25,
-      },
-      {
-        type: "call",
-        count: 30,
-      },
-    ]
-
-    beforeEach(() => {
-      fetchMock.mockResponse(JSON.stringify(analyticsData))
-    })
-
-    it("fetches the data", async () => {
-      const data = await fetchLeadsInteractionsAnalytics({
-        dealerId: 123,
-        dimensions: ["type"],
-        options: { accessToken: "TOKEN" },
-      })
-
-      expect(data).toEqual(analyticsData)
-      expect(fetch).toHaveBeenCalled()
-    })
-
-    it("sends query in the request body", async () => {
-      await fetchLeadsAnalytics({
-        dealerId: 123,
-        options: { accessToken: "TOKEN" },
-      })
-
-      expect(fetch).toHaveBeenCalledWith(
-        expect.stringContaining(`/dealers/123/leads/analytics`),
-        expect.objectContaining({
-          body: JSON.stringify({
-            function: "count",
-          }),
-        })
-      )
-    })
-  })
-
-  describe("#fetchListingsAnalytics", () => {
-    const analyticsData = [
-      {
-        count: 10,
-        makeKey: "audi",
-      },
-      {
-        count: 5,
-        makeKey: "bmw",
-      },
-    ]
-
-    beforeEach(() => {
-      fetchMock.mockResponse(JSON.stringify(analyticsData))
-    })
-
-    it("fetches the data", async () => {
-      const data = await fetchListingsAnalytics({
-        dealerId: 123,
-        dimensions: ["makeKey"],
-        options: { accessToken: "TOKEN" },
-      })
-
-      expect(data).toEqual(analyticsData)
-      expect(fetch).toHaveBeenCalled()
-    })
-
-    it("sends dimensions in the request body", async () => {
-      await fetchListingsAnalytics({
-        dealerId: 123,
-        dimensions: ["makeKey"],
-        options: { accessToken: "TOKEN" },
-      })
-
-      expect(fetch).toHaveBeenCalledWith(
-        expect.stringContaining(`/dealers/123/listings/analytics`),
-        expect.objectContaining({
-          body: JSON.stringify({
-            function: "count",
-            dimensions: ["makeKey"],
-          }),
-        })
-      )
-    })
-  })
-
   describe("#fetchDealerAnalytics", () => {
     const tilesData: DealerAnalytics[] = [
       {

diff --git a/src/services/analytics.ts b/src/services/analytics.ts
@@ -1,8 +1,4 @@
-import {
-  CockpitAnalytics,
-  DealerAnalytics,
-  DealerListingsAnalyticsData,
-} from "../types/models"
+import { DealerAnalytics, DealerListingsAnalyticsData } from "../types/models"
 import { ApiCallOptions, postData } from "../base"
 
 export const fetchAnalyticsData = async ({
@@ -26,72 +22,6 @@ export const fetchAnalyticsData = async ({
   })
 }
 
-export const fetchListingsAnalytics = async ({
-  dealerId,
-  dimensions,
-  options = {},
-}: {
-  dealerId: number
-  dimensions?: string[]
-  options?: ApiCallOptions
-}): Promise<Array<CockpitAnalytics>> => {
-  return postData({
-    path: `dealers/${dealerId}/listings/analytics`,
-    body: {
-      function: "count",
-      dimensions,
-    },
-    options: {
-      isAuthorizedRequest: true,
-      ...options,
-    },
-  })
-}
-
-export const fetchLeadsAnalytics = async ({
-  dealerId,
-  dimensions,
-  options = {},
-}: {
-  dealerId: number
-  dimensions?: string[]
-  options?: ApiCallOptions
-}): Promise<Array<CockpitAnalytics>> => {
-  return postData({
-    path: `dealers/${dealerId}/leads/analytics`,
-    body: {
-      function: "count",
-      dimensions,
-    },
-    options: {
-      isAuthorizedRequest: true,
-      ...options,
-    },
-  })
-}
-
-export const fetchLeadsInteractionsAnalytics = async ({
-  dealerId,
-  dimensions,
-  options = {},
-}: {
-  dealerId: number
-  dimensions?: string[]
-  options?: ApiCallOptions
-}): Promise<Array<CockpitAnalytics>> => {
-  return postData({
-    path: `dealers/${dealerId}/lead-interactions/analytics`,
-    body: {
-      function: "count",
-      dimensions,
-    },
-    options: {
-      isAuthorizedRequest: true,
-      ...options,
-    },
-  })
-}
-
 export const fetchDealerAnalytics = async ({
   dealerId,
   dimensions,