Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude CiliumIdentity kind during listing resources #751

Merged
merged 1 commit into from
May 15, 2023

Conversation

praveenrewar
Copy link
Member

@praveenrewar praveenrewar commented May 11, 2023

What this PR does / why we need it:

Exclude CiliumIdentity kind during listing resources
This is a temporary fix for #748. In future, we will make exclusion of resources configurable via kapp configuration

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?


Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


@praveenrewar praveenrewar linked an issue May 11, 2023 that may be closed by this pull request
@praveenrewar praveenrewar force-pushed the ignore-resources branch 2 times, most recently from cf656e8 to 15b0960 Compare May 15, 2023 12:12
Copy link
Contributor

@100mik 100mik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Let's track making this configurable via config in an issue or the same issue 🚀

@praveenrewar praveenrewar marked this pull request as ready for review May 15, 2023 12:16
@kumaritanushree
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants