Skip to content

Commit

Permalink
V0.34.0 deps bump (#302)
Browse files Browse the repository at this point in the history
* Fix comment spacing

Signed-off-by: Joao Pereira <[email protected]>

* Change golang version to 1.19

Signed-off-by: Joao Pereira <[email protected]>

Signed-off-by: Joao Pereira <[email protected]>
  • Loading branch information
joaopapereira authored Dec 1, 2022
1 parent e9e1b30 commit 18f7bc3
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
go-version: "1.18"
go-version: "1.19.3"
- uses: actions/checkout@v2
with:
fetch-depth: '0'
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
version: v1.45.2
version: v1.50.1
args: -v

2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v2
with:
go-version: 1.18
go-version: 1.19.3

- name: Run GoReleaser
# GoReleaser v2.5.0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-gh.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Set up Go 1.x
uses: actions/setup-go@v2
with:
go-version: "1.18"
go-version: "1.19"
- name: Check out code into the Go module directory
uses: actions/checkout@v2
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/trivy-scan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
with:
repo: vmware-tanzu/carvel-kbld
tool: kbld
goVersion: 1.18
goVersion: 1.19.3
secrets:
githubToken: ${{ secrets.GITHUB_TOKEN }}
slackWebhookURL: ${{ secrets.SLACK_WEBHOOK_URL }}
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/vmware-tanzu/carvel-kbld

go 1.18
go 1.19

require (
github.com/cppforlife/cobrautil v0.0.0-20200514214827-bb86e6965d72
Expand Down
2 changes: 1 addition & 1 deletion hack/Dockerfile.dev
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.18
FROM golang:1.19

RUN apt-get update -y
RUN apt-get install docker.io apt-transport-https ca-certificates gnupg python -y
Expand Down
3 changes: 2 additions & 1 deletion pkg/kbld/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,8 @@ func (d Config) WriteToFile(path string) error {
}

// Equal reports whether this ImageOverride is equal to another ImageOverride.
// (`ImageMeta` is descriptive — not identifying — so not part of equality)
//
// (`ImageMeta` is descriptive — not identifying — so not part of equality)
func (d ImageOverride) Equal(other ImageOverride) bool {
return d.ImageRef == other.ImageRef &&
d.NewImage == other.NewImage &&
Expand Down

0 comments on commit 18f7bc3

Please sign in to comment.