Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DOI for NREL ATB to get error corrections #3778

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

zaneselvans
Copy link
Member

@zaneselvans zaneselvans commented Aug 10, 2024

Overview

Update Zenodo DOI for NREL ATB dataset to get their error corrections.

Closes #3777

Testing

  • I re-ran the ETL for the NREL ATB assets locally.
  • I checked whether there are any data validation tests for the ATB, and there aren't, so I didn't re-run the minmax rows.

To-do list

Preview Give feedback

@zaneselvans zaneselvans added nrelatb NREL's Annual Technology Baseline data data-update When fresh data is integrated into PUDL from quarterly or annual updates labels Aug 10, 2024
@zaneselvans zaneselvans self-assigned this Aug 10, 2024
@zaneselvans zaneselvans requested a review from e-belfer August 10, 2024 02:50
@zaneselvans zaneselvans enabled auto-merge August 10, 2024 03:11
Copy link
Member

@e-belfer e-belfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious if this had any impact on the scale of duplicated data with different core_metric_key's, but otherwise looks good!

@zaneselvans zaneselvans added this pull request to the merge queue Aug 12, 2024
@zaneselvans
Copy link
Member Author

The errata they published seemed to be about updating some values.

Merged via the queue into main with commit da9ade7 Aug 12, 2024
14 checks passed
@zaneselvans zaneselvans deleted the nrelatb-2024q2-update branch August 12, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-update When fresh data is integrated into PUDL from quarterly or annual updates nrelatb NREL's Annual Technology Baseline data
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

NREL ATB 2024Q2 Update
2 participants