Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tmux-clima as another module for weather #161

Merged
merged 5 commits into from
Mar 18, 2024
Merged

Conversation

xafarr
Copy link
Contributor

@xafarr xafarr commented Mar 15, 2024

@vdbe
Copy link
Contributor

vdbe commented Mar 16, 2024

What does this plugin provide that the the current weather module doesn't?
It seems to also use OpenWeatherMap so the result are the same I guess (and you need your own api key).

Before merging this it needs documentation in the README.

@xafarr
Copy link
Contributor Author

xafarr commented Mar 17, 2024

It does the same thing but in a different way. Also, tmux-weather is pretty inactive. And tmux-clima can be an extra option for people to use with catppuccin/tmux. Updated the PR with README update. Thanks.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@vdbe
Copy link
Contributor

vdbe commented Mar 17, 2024

It currently does not do anything extra except set prefix+W.
I will leave this open in case this changes and for further discussion/requests.

@vdbe vdbe linked an issue Mar 17, 2024 that may be closed by this pull request
@xafarr xafarr closed this Mar 18, 2024
@xafarr xafarr reopened this Mar 18, 2024
@xafarr
Copy link
Contributor Author

xafarr commented Mar 18, 2024

I have been using tmux-clima for almost 2 years and contribute to it as well. I also like catppuccin project and use it in all terminal programs. I raised this PR for people like me to have an option to use these together. I used to use tmux-weather but was constantly having problems with wttr.in. That was the reason I moved to this plugin. OpenWeatherMap API is pretty stable and gives free 1000 calls per day.

@vdbe vdbe merged commit d0371ba into catppuccin:main Mar 18, 2024
3 checks passed
@xafarr xafarr deleted the tmux-clima branch March 18, 2024 23:47
Andreasgdp added a commit to Andreasgdp/tmux-catppuccin that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tmux-clima as an additional module for weather
2 participants