-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amend/tekton helm charts #47
Amend/tekton helm charts #47
Conversation
/cc @tomhobson @msvticket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see where we are combining the service accounts here
As discussed. I think the combining of the service accounts is incorrect as better to have the two different service accounts that work with the services they are bound to. resolvers and controller. So fixing the namespace they are deployed to, fix the issue. |
e9b157f
to
7103536
Compare
fixes: #19 |
/cc @msvticket |
approving and merging as k8s 1.24 is becoming unsupported at the end of this month |
Issue with tekton-helm-chart deploying a tekton-pipelines-resolvers ns that is not necessary for tekton-pipelines to work.
Amending makefile to render charts with yq in order to: