Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend/tekton helm charts #47

Merged

Conversation

mentlak0
Copy link
Collaborator

@mentlak0 mentlak0 commented Jun 1, 2023

Issue with tekton-helm-chart deploying a tekton-pipelines-resolvers ns that is not necessary for tekton-pipelines to work.

Amending makefile to render charts with yq in order to:

  • remove tekton-pipelines-resolvers-ns.yaml (stop deployment of the ns)
    
  • insert '{{  .Release.namespace }}' in subject.namespace to overwrite tekton-pipelines-resolver manifest for crb
    
  • delete namespace from tekton-pipelines charts to allow correct install with helm
    
  • make fetch v0.42.0 applied
    

@mentlak0 mentlak0 marked this pull request as ready for review June 1, 2023 09:30
@mentlak0
Copy link
Collaborator Author

mentlak0 commented Jun 1, 2023

/cc @tomhobson @msvticket

@tomhobson tomhobson requested a review from msvticket June 1, 2023 14:00
Copy link
Collaborator

@tomhobson tomhobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see where we are combining the service accounts here

@tomhobson tomhobson self-requested a review June 1, 2023 14:44
@mentlak0
Copy link
Collaborator Author

mentlak0 commented Jun 1, 2023

I can't see where we are combining the service accounts here

As discussed. I think the combining of the service accounts is incorrect as better to have the two different service accounts that work with the services they are bound to. resolvers and controller. So fixing the namespace they are deployed to, fix the issue.

@tomhobson
Copy link
Collaborator

fixes: #19

@tomhobson
Copy link
Collaborator

/cc @msvticket

@tomhobson
Copy link
Collaborator

approving and merging as k8s 1.24 is becoming unsupported at the end of this month

@tomhobson tomhobson merged commit 63f752e into cdfoundation:main Jun 6, 2023
@mentlak0 mentlak0 deleted the amend/tekton-helm-charts branch July 10, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants