Add codex/codex-icons/codex-design-tokens w/ npm auto-update #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codex [1] is the design system for Wikimedia. Having it available on cdnjs will be useful for developers of Wikimedia-related tools who want to match the design of Wikimedia sites (see also T338834 [2]). The unscoped codex npm package [3] has not been updated in over ten years (and as “a simple tool for building static [websites]” probably would not be very useful on cdnjs anyways), so I hope nobody will mind using the unprefixed codex name directly for @wikimedia/codex. (There seems to be some precedent for this among existing npmjs packages too, such as angular for @angular/core or treejs for @widgetjs/tree.) [1]: https://www.mediawiki.org/wiki/Special:MyLanguage/Codex [2]: https://phabricator.wikimedia.org/T338834 [3]: https://www.npmjs.com/package/codex
|
For convenience, checking against the popularity policy:
The unscoped |
lucaswerkmeister
changed the title
MattIPv4
changed the title
MattIPv4
reviewed
Jul 16, 2023
Co-authored-by: Matt Cowley <[email protected]>
|
Thanks! codex is working fine, but codex-icons and codex-design-tokens 404 and I don’t know why… do libraries without JS files automatically get filtered out, perhaps? |
|
It looks like they haven't been processed yet: https://github.com/cdnjs/logs/commits/prod |
|
I see, thanks. |
|
You’re right, now they’re both there. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codex is the design system for Wikimedia. Having it available on cdnjs will be useful for developers of Wikimedia-related tools who want to match the design of Wikimedia sites (see also T338834).
The unscoped
codexnpm package has not been updated in over ten years (and as “a simple tool for building static [websites]” probably would not be very useful on cdnjs anyways), so I hope nobody will mind using the unprefixedcodexname directly for@wikimedia/codex. (There seems to be some precedent for this among existing npmjs packages too, such asangularfor@angular/coreortreejsfor@widgetjs/tree.)