Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update canvasjs w/ npm auto-update #1632

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 41 additions & 12 deletions packages/c/canvasjs.json
Original file line number Diff line number Diff line change
@@ -1,16 +1,45 @@
{

Check failure on line 1 in packages/c/canvasjs.json

View workflow job for this annotation

GitHub Actions / robotcdnjs

repository: type is required

Check failure on line 1 in packages/c/canvasjs.json

View workflow job for this annotation

GitHub Actions / robotcdnjs

repository: url is required

Check failure on line 1 in packages/c/canvasjs.json

View workflow job for this annotation

GitHub Actions / robotcdnjs

repository: Additional property private is not allowed
"name": "canvasjs",
"filename": "canvasjs.min.js",
"description": "CanvasJS is an easy to use HTML5 & JavaScript Charting library built on Canvas element.",
"homepage": "http://canvasjs.com/",
"keywords": [
"canvas",
"charts"
],
"license": "Creative Commons Attribution-NonCommercial 3.0",
"authors": [
"name":"canvasjs",
"filename":"canvasjs.min.js",
"description":"CanvasJS is a JavaScript Charting Library for creating interactive charts & graphs for your web pages. Library supports a wide range of chart types including bar, line, area, pie, doughnut charts, etc. Charts work with all the popular Technologies & Frameworks like React, Angular, jQuery, PHP, etc.",
"homepage":"https://canvasjs.com/",
"license":"SEE LICENSE IN <LICENSE>",
"autoupdate":{
"source":"npm",
"target":"@canvasjs/charts",
"fileMap":[
{
"basePath":"",
"files":[
"*.js"
]
}
]
},
"authors":[
{
"name": "fenopix"
"name":"fenopix"
}
],
"repository":{
"private":true
},
Comment on lines +24 to +26
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the CI error notes, cdnjs requires that the repository field be populated with an actual open-source repository.

"keywords":[
"javascript charts",
"javascript graphs",
"javascript charting library",
"javascript chart library",
"html5 charts",
"charts",
"graphs",
"dataviz",
"js charts",
"canvasjs",
"canvas",
"high performance charts",
"line charts",
"area charts",
"bar charts",
"pie charts"
]
}
}
Loading