Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add css-scope-inline w/ git auto-update #1831

Merged
merged 4 commits into from
Aug 11, 2024

Conversation

jph00
Copy link
Contributor

@jph00 jph00 commented Jun 26, 2024

Adding CSS Scope Inline library to cdnjs.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the CI error indicates, to pull from a GitHub repository, there needs to be tags for each version that we should pull into cdnjs.

@jph00
Copy link
Contributor Author

jph00 commented Jul 17, 2024

This should be fixed now too.

@jph00 jph00 requested a review from MattIPv4 July 24, 2024 02:57
@jph00
Copy link
Contributor Author

jph00 commented Aug 4, 2024

Understood @MattIPv4 -- I reached out to the author once already since I also felt that would be preferred, but didn't get a response. I've actually set up an automatic release github workflow on the fork which pulls directly from the source repo. AFAICT there's no particular reason to believe the source repo would be less likely to have sketchy stuff going on than my version!

If I'm not able to get a response from the original author, what could I do to create a new project based on the original which you'd be comfortable adding to cdnjs? Would I need to give it a new name? In general I assume there's a way for project forks to be added to cdnjs -- quite often forks become more popular than the originals?

@gnat
Copy link

gnat commented Aug 4, 2024

Hey @MattIPv4 , I'm the author of both of these libraries.

In this specific case, I feel the fork is OK for cdnjs, because:

  • I do not plan to add tagged releases to either project, specifically because I do not want to railroad new developers into thinking they need to use build machinery.
    • One of the main goals of these projects is to service new developers, to be real legit examples of libraries you can just download or copy/paste to work.
  • Both projects currently have CDN hosted on https://www.jsdelivr.com
    • I explicitly chose jsdelivr because no tagging is required.
    • Unless there's a downside to jsdelivr I'm not considering??
  • @jph00 requires the use of cdnjs because of a commercial product that only supports cdnjs.
    • I do not plan to add build machinery just to accommodate the commercial entity- they could add jsdelivr tomorrow and this conversation is moot.

Part of the whole idea behind surreal, css-scope-inline (and IMHO, htmx) is they are useful projects you can just paste the script in and have it work without new developers feeling like they are being railroaded into a toolchain pipeline, which often distracts and clouds their understanding and make them a captive audience to that machinery.

Apologies for dragging you into this. I understand we all have limited bandwidth to make workarounds for private companies.

@jph00 jph00 requested a review from MattIPv4 August 4, 2024 23:02
@MattIPv4
Copy link
Member

Understood, thank you for the context! Given that, I'll let this go through with the different source repo.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MattIPv4 MattIPv4 merged commit ec25849 into cdnjs:master Aug 11, 2024
1 check passed
@jph00
Copy link
Contributor Author

jph00 commented Aug 13, 2024

@MattIPv4 thanks for your help. Question: surreal.js is showing up in the cdn, but this one (css-scope-inline) isn't-- does it just take a while?

@jph00
Copy link
Contributor Author

jph00 commented Aug 13, 2024

Apologies, I figured out the source of the problem - pebkac... Made a PR to fix.

@jph00 jph00 deleted the add-css-scope-inline branch August 13, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants