-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add css-scope-inline w/ git auto-update #1831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the CI error indicates, to pull from a GitHub repository, there needs to be tags for each version that we should pull into cdnjs.
This should be fixed now too. |
Understood @MattIPv4 -- I reached out to the author once already since I also felt that would be preferred, but didn't get a response. I've actually set up an automatic release github workflow on the fork which pulls directly from the source repo. AFAICT there's no particular reason to believe the source repo would be less likely to have sketchy stuff going on than my version! If I'm not able to get a response from the original author, what could I do to create a new project based on the original which you'd be comfortable adding to cdnjs? Would I need to give it a new name? In general I assume there's a way for project forks to be added to cdnjs -- quite often forks become more popular than the originals? |
Hey @MattIPv4 , I'm the author of both of these libraries. In this specific case, I feel the fork is OK for cdnjs, because:
Part of the whole idea behind surreal, css-scope-inline (and IMHO, htmx) is they are useful projects you can just paste the script in and have it work without new developers feeling like they are being railroaded into a toolchain pipeline, which often distracts and clouds their understanding and make them a captive audience to that machinery. Apologies for dragging you into this. I understand we all have limited bandwidth to make workarounds for private companies. |
Understood, thank you for the context! Given that, I'll let this go through with the different source repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@MattIPv4 thanks for your help. Question: surreal.js is showing up in the cdn, but this one (css-scope-inline) isn't-- does it just take a while? |
Apologies, I figured out the source of the problem - pebkac... Made a PR to fix. |
Adding CSS Scope Inline library to cdnjs.