-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for missing operands, invalid method names and invalid variables to 'tolerant-ast' experimental feature #1489
Open
eidelmanjonathan
wants to merge
37
commits into
cedar-policy:main
Choose a base branch
from
eidelmanjonathan:missing-second-operand
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
712e0ae
to
453d268
Compare
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
286f493
to
8a00404
Compare
Signed-off-by: Jonathan Eidelman <[email protected]>
Signed-off-by: Jonathan Eidelman <[email protected]>
71169c3
to
2ca268b
Compare
Signed-off-by: Jonathan Eidelman <[email protected]>
Coverage ReportHead Commit: Base Commit: Download the full coverage report. Coverage of Added or Modified Lines of Rust CodeRequired coverage: 80.00% Actual coverage: 86.30% Status: PASSED ✅ Details
Coverage of All Lines of Rust CodeRequired coverage: 80.00% Actual coverage: 87.05% Status: PASSED ✅ Details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change expands the 'tolerant-ast' experimental feature to allow for several more error cases to be parsed into partial AST's. This allows us to succeed even if the policy has errors in it.
This change allows us to support the following new cases which will be helpful in creating a better LSP Autocomplete feature in the future:
permit(principal ==, action, resource);
permit ( principal,action,resource) when { ip(principal.ip).i() };
permit ( principal,action,resource) when { pri }
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy
(e.g., changes to the signature of an existing API).cedar-policy
(e.g., addition of a new API).cedar-policy
.cedar-policy-core
,cedar-validator
, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec
(choose one, and delete the other options):cedar-spec
, and how you have tested that your updates are correct.)cedar-spec
. (Post your PR anyways, and we'll discuss in the comments.)I confirm that
docs.cedarpolicy.com
(choose one, and delete the other options):cedar-docs
. PRs should be targeted at astaging-X.Y
branch, notmain
.)