more simplification of protobuf schema format (followups to 1488) #1495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
More simplifications of the Protobuf format for
Schema
, some suggested in #1488 and some based on conversations with @john-h-kastner-aws offline.Schema
is just a list ofEntityDecl
and a list ofActionDecl
, not a map, as this is simpler and sufficientcontext
for an Action must be a record, so instead ofType
, we require it to be amap<string, AttributeType>
Type.Ty
toType.Prim
which is more clearNever
,True
,False
,EmptySet
, andAnyEntity
types, as these should never appear in schemasActionEntity
type as action entities can just be encoded asEntity
type (we do not support action attributes in Protobuf, as that is not a stable feature)EntityRecordKind
in favor of inlining it intoType
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec
(choose one, and delete the other options):cedar-spec
, and how you have tested that your updates are correct.)I confirm that
docs.cedarpolicy.com
(choose one, and delete the other options):