Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed encode queryParameters to perpercent-encoded #2381

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

m430
Copy link

@m430 m430 commented Feb 13, 2025

#1603
#1445

现在queryParameters的编码使用的是Uri.encodeQueryComponent,这个方法使用的规范并不是常用的,通常使用perpercent-encoded是更常规的做法,比如把

空格转为成"%20"而不是"+"

@m430 m430 requested a review from a team as a code owner February 13, 2025 07:04
Copy link
Contributor

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
Overall Coverage 🟢 84.79% 🟢 84.79% ⚪ 0%

Minimum allowed coverage is 0%, this run produced 84.79%

@AlexV525
Copy link
Member

PR 需要测试
修改后对于原有项目来说会是破坏性变更,我们无法接受这样的修改。我倾向于该方法能够通过某些手段暴露出来,能自定义处理并且保留原有的逻辑以避免破坏原有用法。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants