Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #30 and fixes #36
I ran into a very rare intermittent failure in a test which starts a Qt application and connects to a virtual framebuffer constructed with xvfb. The cause was the race condition between xvfb creating the framebuffer and the Qt application starting.
Under normal circumstances the error is quite rare (happening in 1/2500 runs or so) but the same situation can be emulated with:
which crashes almost immediately with
I have replaced the fixed timeout with a loop which waits for the Unix domain socket for the display to exist (which I assume means the display is ready). With this change the above snippet no longer crashes.
An added benefit is that the startup is also much faster (taking only about 5ms on average on my machine).
I know the chances of getting this pull request merged is slim as the project seems abandoned, but this might be useful for other people who run into this problem.