Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ignored/private packages on "add a changeset if you're a maintainer" link #44

Open
wlee221 opened this issue Nov 4, 2021 · 0 comments

Comments

@wlee221
Copy link

wlee221 commented Nov 4, 2021

Related Issues:

#39: Same root cause, but different use case.
changesets/changesets#436: same issue in CLI.

Problem:

Hi, I've been really enjoying the DX of "add a changeset if you're a maintainer". But whenever a PR modifies both public and ignored/private packages, changeset/bot lists all of them in the yaml header. If we don't remove those ignored/private packages manually, this will throw

Mixed changesets that contain both ignored and not ignored packages are not allowed

Example PR: aws-amplify/amplify-ui#628. This repository has private docs and e2e packages that are ignored, but they still show up in the "add a changeset" link.

Expected Behavior

Remove ignored and/or private packages from changed packages list. This will especially help external contributors that aren't too familiar with the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant