Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document: add description for injecting JVM fault into MySQL client #317

Merged
merged 4 commits into from
Jul 5, 2022
Merged

document: add description for injecting JVM fault into MySQL client #317

merged 4 commits into from
Jul 5, 2022

Conversation

WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC commented Jun 28, 2022 •
edited
Loading

Signed-off-by: xiang [email protected]
fix issue #245

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 28, 2022
@WangXiangUSTC WangXiangUSTC requested review from STRRL and Oreoxmt June 28, 2022 08:20
@netlify
Copy link

netlify bot commented Jun 28, 2022 •
edited
Loading

✅ Deploy Preview for chaos-mesh-website-preview ready!

Name Link
🔨 Latest commit c2c7137
🔍 Latest deploy log https://app.netlify.com/sites/chaos-mesh-website-preview/deploys/62bbd052ef3f510008f92ac8
😎 Deploy Preview https://deploy-preview-317--chaos-mesh-website-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Oreoxmt Oreoxmt added documentation Additions or improvements to documentation type/bugfix This PR fixes a bug. type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR's assignee is translating this PR. labels Jun 28, 2022
Oreoxmt
Oreoxmt reviewed Jun 28, 2022
View reviewed changes
@Oreoxmt Oreoxmt force-pushed the java_mysql_client branch from 74980e5 to 3a64955 Compare June 28, 2022 09:14
@Oreoxmt Oreoxmt added the v2.3 label Jun 28, 2022
@WangXiangUSTC WangXiangUSTC added type/bugfix This PR fixes a bug. and removed type/bugfix This PR fixes a bug. labels Jun 29, 2022
@WangXiangUSTC
address comment
710f9f3 
Signed-off-by: xiang <[email protected]>
@WangXiangUSTC
merge
c2c7137 
Signed-off-by: xiang <[email protected]>
@WangXiangUSTC
Copy link
Contributor Author

@Oreoxmt PTAL again

Oreoxmt
Oreoxmt approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 29, 2022
@Oreoxmt Oreoxmt changed the title document: add description for injecting JVM fault into MyAQL client document: add description for injecting JVM fault into MySQL client Jul 1, 2022
cwen0
cwen0 approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Jul 5, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c2c7137

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 5, 2022
@ti-chi-bot ti-chi-bot merged commit de9fbce into chaos-mesh:master Jul 5, 2022
varunkothamachu pushed a commit to microdao-bio/website-microdao-bio that referenced this pull request Dec 29, 2024
@WangXiangUSTC @Oreoxmt
document: add description for injecting JVM fault into MySQL client (c…
9243fb8 
…haos-mesh#317)

* add description for mysql client

Signed-off-by: xiang <[email protected]>

* Apply suggestions from code review

Signed-off-by: Aolin <[email protected]>

* address comment

Signed-off-by: xiang <[email protected]>

Co-authored-by: Aolin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwen0 cwen0 cwen0 approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@STRRL STRRL Awaiting requested review from STRRL

Assignees

@WangXiangUSTC WangXiangUSTC

Labels
documentation Additions or improvements to documentation size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/doing This PR's assignee is translating this PR. type/bugfix This PR fixes a bug. type/enhancement The issue or PR belongs to an enhancement. v2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WangXiangUSTC @ti-chi-bot @cwen0 @Oreoxmt