(v2) feat: add adaptive color package #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a helper type `LightDark` that takes a boolean to determine which `Color(light, dark)` to choose from. The `adaptive` package is a helper package that uses the `lipgloss.LightDark` along with querying the terminal when the module is imported to choose the appropriate light-dark color. Example: ```go var ( light = "#0000ff" dark = "#ff0000" ) colorToUse := adaptive.Color(light, dark) // the terminal is queried before choosing the color fmt.Println(colorToUse) ```
aymanbagabas
changed the title
5 tasks
bashbunni
reviewed
Oct 11, 2024
| // dark := "#ff0000" | ||
| // colorToUse := useDark.Color(light, dark) | ||
| // fmt.Println(colorToUse) | ||
| type LightDark bool |
There was a problem hiding this comment.
What do you think about naming this Adapt instead? Might feel more familiar.
Then it could be
adaptive := lipgloss.Adapt(true)
colors := adaptive.Color("#0000ff", "#ff0000")
I think that would make the purpose more clear
There was a problem hiding this comment.
Totally: this is really nice.
There was a problem hiding this comment.
I would also update the comment to show use with Bubble Tea, as well as standalone Lip Gloss (when we get there).
There was a problem hiding this comment.
I'm thinking of dropping this type which is basically an ifelse; the adaptive sub-package should be enough imo
meowgorithm
requested changes
Oct 11, 2024
| // dark := "#ff0000" | ||
| // colorToUse := useDark.Color(light, dark) | ||
| // fmt.Println(colorToUse) | ||
| type LightDark bool |
There was a problem hiding this comment.
I would also update the comment to show use with Bubble Tea, as well as standalone Lip Gloss (when we get there).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a helper type
LightDarkthat takes a boolean to determine whichColor(light, dark)to choose from. Theadaptivepackage is a helper package that uses thelipgloss.LightDarkalong with querying the terminal when the module is imported to choose the appropriate light-dark color.This will also make
lipgloss.Colortakeanytype and try to infer the color from either strings or integers.Example: