-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add WindowTitle setting #507
base: main
Are you sure you want to change the base?
Conversation
Wow, this looks awesome. Would totally vouch for this to be implemented! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great, thank you!
i do think the font of the title could be a bit smaller though... 🤔
Agreed, this one isn’t quite there yet in terms of typography. Can we bump it down a hair and ensure that it only uses exactly the same typeface as the terminal? By default that should be JetBrains Mono (via embedding). It’s very important for the integrity of the project that we get this one right before merging. Also, we’ll need to update the README for this as well. |
Cool, thanks for the feedback. I'll get those changes implemented. |
0d064e4
to
32f0d51
Compare
Just wanted to confirm the expected behaviour for a few scenarios:
Any other scenarios not covered above, please add. Also, should the font file to embed for JetBrains Mono be included in the repo, or add a script/make target to download it from JetBrains at build time, or some other approach? |
Per issue: #436