Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: update node engine requirement to >=18 [sc-23291] #1001

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

sorccu
Copy link
Contributor

@sorccu sorccu commented Dec 10, 2024

The reason for this change is that new versions of many of our dependencies now require Node 18 or later, meaning we cannot update them without breaking compatibility. Bumping our Node version in a major release makes that possible again.

This is a breaking change (despite probably no one using Node 16 anymore), so a new major version is required.

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Resolves #[issue-number]

New Dependency Submission

@sorccu sorccu force-pushed the update-engines-requirement branch from c95e76b to fad7067 Compare December 10, 2024 15:58
@sorccu sorccu changed the title chore: update node engine requirement to >=18 chore!: update node engine requirement to >=18 Dec 10, 2024
@hdf1996
Copy link

hdf1996 commented Dec 18, 2024

Additionally, looks like #991 already took care of updating the github actions to use 18.x, so this should be fine

@tnolet tnolet added this to the 5.0.x milestone Feb 19, 2025
@sorccu sorccu force-pushed the update-engines-requirement branch from fad7067 to 0e0827c Compare February 19, 2025 11:45
@sorccu sorccu changed the title chore!: update node engine requirement to >=18 chore!: update node engine requirement to >=18 [sc-23291] Feb 19, 2025
BREAKING CHANGE: Node <18 is no longer supported.
@sorccu sorccu force-pushed the update-engines-requirement branch from 0e0827c to 8fb2604 Compare February 19, 2025 11:47
@sorccu sorccu merged commit 18857dc into main Feb 19, 2025
3 checks passed
@sorccu sorccu deleted the update-engines-requirement branch February 19, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants