Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TcpCheck construct [sc-22430] #1012

Conversation

sorccu
Copy link
Contributor

@sorccu sorccu commented Jan 21, 2025

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Resolves #[issue-number]

New Dependency Submission

@sorccu sorccu requested a review from ejanusevicius January 21, 2025 14:39
@sorccu sorccu force-pushed the edvinasjanueviius/sc-22430/cli-update-next-test-sessions-trigger-endpoint branch 2 times, most recently from 3f85545 to 49263e5 Compare January 24, 2025 12:10
The property could be a regex, like with API checks and TEXT_BODY, so
expose it after all.

This reverts commit 2c7b8b8.
@sorccu sorccu requested a review from ejanusevicius January 28, 2025 14:57
@sorccu sorccu force-pushed the edvinasjanueviius/sc-22430/cli-update-next-test-sessions-trigger-endpoint branch from b01d6a8 to f1adc09 Compare January 28, 2025 15:58
@sorccu sorccu merged commit 9331762 into main Jan 29, 2025
3 checks passed
@sorccu sorccu deleted the edvinasjanueviius/sc-22430/cli-update-next-test-sessions-trigger-endpoint branch January 29, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants