Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds degraded state to reporters [sc-00] #1020

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

tnolet
Copy link
Member

@tnolet tnolet commented Feb 17, 2025

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

This PR adds the "degraded" state to all relevant points, mostly in the reporters. Previously all interactions with "degraded" states (e.g. test and trigger) all reported a "degraded" check as "passed / successful". It reports the "degraded" state with a ⚠️ icon and yellow text.

  • adds to ci, dot, list and github reporters.
  • adds to abtract list and summary.
  • adds a small helper to not have double ternary statements everywhere.
  • adds tests.

CleanShot 2025-02-17 at 13 44 29

@tnolet tnolet requested a review from sorccu February 17, 2025 12:46
Copy link
Contributor

@sorccu sorccu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@tnolet tnolet merged commit 9072477 into main Feb 18, 2025
3 checks passed
@tnolet tnolet deleted the tnolet/sc-00/add-degraded-state branch February 18, 2025 09:36
@tnolet tnolet added this to the 5.0.x milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants